Previous in sink decouple madsim test, we assume that the sink writer of all sink parallelisms should be created after the create sink SQL returns. However, when sink decouple is enabled, the sink writer will be created in the log reader side, which is decoupled from the upstream. Therefore, it may happen that when the create sink SQL returns, not all sink writer have been created, and some related tests become flaky. In this PR, we change to explicitly wait for all sink writer parallelisms to be created before proceeding to next step, and the flaky tests will be fixed.
Checklist
[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)
Documentation
[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previous in sink decouple madsim test, we assume that the sink writer of all sink parallelisms should be created after the create sink SQL returns. However, when sink decouple is enabled, the sink writer will be created in the log reader side, which is decoupled from the upstream. Therefore, it may happen that when the create sink SQL returns, not all sink writer have been created, and some related tests become flaky. In this PR, we change to explicitly wait for all sink writer parallelisms to be created before proceeding to next step, and the flaky tests will be fixed.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.