If the shutdown_tx returned by the function is not retained, then shutdown_rx will receive an exit message and the shared compactor loop will be terminated.
This pr maintains the lifetime of the start_shared_compactor return value to avoid this problem.
This PR is just a hot fix, and does not prevent serverless compactor v2.0.x from being tested.
If necessary, a separate PR will be launched to address the compactor graceful shutdown and cancel task issues.
Checklist
[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)
Documentation
[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
If the
shutdown_txreturned by the function is not retained, thenshutdown_rxwill receive an exit message and the shared compactor loop will be terminated.This pr maintains the lifetime of the
start_shared_compactorreturn value to avoid this problem.This PR is just a hot fix, and does not prevent serverless compactor v2.0.x from being tested. If necessary, a separate PR will be launched to address the compactor graceful shutdown and cancel task issues.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.