search

risingwavelabs / risingwave

SQL stream processing, analytics, and management. We decouple storage and compute to offer efficient joins, instant failover, dynamic scaling, speedy bootstrapping, and concurrent query serving.
https://www.risingwave.com/slack
Apache License 2.0
6.64k stars 545 forks source link

bug: distributed lookup join may use inconsistent vnode mapping infos #9041

Closed zwang28 closed 2 weeks ago

zwang28 commented 1 year ago

Describe the bug

In frontend, distributed lookup join reads vnode mapping of inner side table twice:

  1. Get ExchangeInfo: https://github.com/risingwavelabs/risingwave/blob/3091f1686ed40992768c5fbfec960b89b8c492f9/src/frontend/src/optimizer/property/distribution.rs#L148
  2. Get parallelism: https://github.com/risingwavelabs/risingwave/blob/3091f1686ed40992768c5fbfec960b89b8c492f9/src/frontend/src/scheduler/plan_fragmenter.rs#L945

If the vnode mapping changes between these 2 steps (e.g. scaling), query result may be incorrect.

To Reproduce

No response

Expected behavior

No response

Additional context

No response

github-actions[bot] commented 3 weeks ago

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean. Don't worry if you think the issue is still valuable to continue in the future. It's searchable and can be reopened when it's time. 😄