search

risingwavelabs / risingwave

Best-in-class stream processing, analytics, and management. Perform continuous analytics, or build event-driven applications, real-time ETL pipelines, and feature stores in minutes. Unified streaming and batch. PostgreSQL compatible.
https://go.risingwave.com/slack
Apache License 2.0
7.06k stars 580 forks source link

bug: The dbz format is allowed to be created when using backhole sink. #9440

Closed neverchanje closed 2 months ago

neverchanje commented 1 year ago

Describe the bug

create table t (v1 int, v2 int);
create sink invalid_dbz_type_sink from t with (connector = 'blackhole', type = 'debezium');

Expected behavior

It's supposed to fail but actually succeeded.

Additional context

NOTE: Once fixed, please add the above test case in e2e_test/sink/append_only_sink.slt.

xx01cyx commented 1 year ago

I believe we should introduce a better framework to check sink configurations in the connector node. We should be able to define fields as optional or required and specify possible values for each field in an easy way. cc @wenym1

github-actions[bot] commented 1 year ago

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

fuyufjh commented 1 year ago

@tabVersion Can you please take a look?

tabVersion commented 1 year ago

@tabVersion Can you please take a look?

@neverchanje what type is accepted in blackhole sink? or blackhole sink should not work with type attr

github-actions[bot] commented 4 months ago

This issue has been open for 60 days with no activity.

If you think it is still relevant today, and needs to be done in the near future, you can comment to update the status, or just manually remove the no-issue-activity label.

You can also confidently close this issue as not planned to keep our backlog clean. Don't worry if you think the issue is still valuable to continue in the future. It's searchable and can be reopened when it's time. 😄