search

risk-of-thunder / RoR2BepInExPack

RoR2BepInExPack
MIT License
1 stars 10 forks source link

Fix lobby compatibility for DLC2 with additional difficulties #34

Closed 6thmoon closed 1 week ago

6thmoon commented 1 week ago

With the Seekers of the Storm update an interface got added to toggle tutorial mode in the lobby. Unfortunately, the changes made to support this cause issues with the difficulty carousel once other options are added, even breaking it entirely if enough are present.

xiaoxiao921/RoR2_diff_20_05_2024:RuleBookViewerStrip.cs@779e6e7#L53-L57

Their implementation does not allow to select any rule choice index greater than the number of available options - this is problematic as those are not always consecutive. A layout element was also removed causing these to overflow and become inaccessible.

https://github.com/TeamMoonstorm/Starstorm2/issues/626 https://github.com/6thmoon/MultitudesDifficulty/issues/8#issuecomment-2461715317

See the reports above for a visual example. Note that those and others affected do not always utilize DifficultyAPI.

6thmoon commented 1 week ago

To clarify, indices of the available choices are not consecutive when any hidden difficulty is involved, as is normally the case due to Eclipse options. Feel free to elaborate if it seems more appropriate to address this elsewhere.