riskable / void_switch

3D printable magnetic separation contactless key switch and stabilizers (OpenSCAD files)
721 stars 43 forks source link

MAGNET_WALL_THICKNESS not honored in "sheath" #19

Closed ivanpointer closed 2 years ago

ivanpointer commented 2 years ago

Setting MAGNET_WALL_THICKNESS changes the body, but in the sheath, the value is hard-coded, creating issues with snapping the sheath and body together when this value is changed - especially decreased.

The solution is to simply specify this value on the sheath in void_switch.scad - the function already has a parameter for it, but because it's not passed, the function uses the hard-coded default of 0.5.

I'll be submitting a PR for this shortly.

ivanpointer commented 2 years ago

Submitted PR #20.