riskersen / Monitoring

Monitoring plugins wich are Nagios/icinga compatible
65 stars 113 forks source link

check_netapp_sdk #17

Closed TryTryAgain closed 8 years ago

TryTryAgain commented 8 years ago

check-license command says UNKNOWN COMMAND. It looks like this isn't finished? Should it work?

It was not found in the command_table, but even if I added it ('check-license' => &check_license,), it still says UNKNOWN COMMAND. Any help is appreciated.

riskersen commented 8 years ago

Hej, you're right, it's missing in the command table but I'm not quite sure why.

So adding it in this table its also exiting with unknown command? In your code sample it's spelled correctly so I assume it should work.

Does it say invalid or unknown command?

TryTryAgain commented 8 years ago

Weird, this time I tried, with "-C check-license", and it said CHECK_NETAPP_SDK.PL CRITICAL - license-list-info failed: This API is no longer supported. Use license-v2-list-info instead. With "-C license-v2-list-info", I then get INVALID COMMAND. When I'd tried it before, I thought I remember -C check-license returning unknown.

TryTryAgain commented 8 years ago

Ah, it now works, changing this:

# $output = $s->invoke( "license-list-info");

$output = $s->invoke( "license-v2-list-info");

Now, to find a way to suppress all the uninitialized value warnings ;-) EDIT: found this solution using no warnings 'uninitialized'; just under the foreach my $license (@result) {

Thanks for the great work! Hope this bug report helps others.

riskersen commented 8 years ago

Thank you for testing, maybe you could provide a patch for this case? Am 25.01.2016 17:53 schrieb "Michael Lawler" notifications@github.com:

Ah, it now works, changing this: $output = $s->invoke( "license-list-info");

$output = $s->invoke( "license-v2-list-info");

Now, to find a way to suppress all the uninitialized value warnings ;-)

Thanks for the great work! Hope this bug report helps others.

— Reply to this email directly or view it on GitHub https://github.com/riskersen/Monitoring/issues/17#issuecomment-174579440 .

riskersen commented 8 years ago

Finally fixed. in aacbf38