search

riskersen / Monitoring

Monitoring plugins wich are Nagios/icinga compatible
65 stars 113 forks source link

Address issues 15 and 16 #18

Closed Napsty closed 8 years ago

Napsty commented 8 years ago

This fixes issues #15 and #16. However on the slave itself there is still an issue (already before this pull request). The wrong serial is taken as slave (probably just assumed that the second found serial is slave, but thats not correct).

riskersen commented 8 years ago

Hi Napsty,

looks not bad for me, but i just tested that the OID with a standalone machine and in this case, the master OID is empty, so we cant use that OID for general purpose. What do you think? I would recommend to check if OID contains a value and then use that oid

BR Oliver

Napsty commented 8 years ago

In this case the OID only exists if the firewall is part of a cluster. Yes, the value of this OID should only be considered if it exists.

Napsty commented 8 years ago

Please test commit 69533e4efab587fb9fe18d44c57cf6116e282a94 if it works. Unfortunately our Fortigate cluster was already uninstalled so I cannot test on the real devices anymore. But you should get the idea.