search

riskmaris / mobile-menu-branch

MIT License
5 stars 0 forks source link

make changes #10

Closed riskmaris closed 1 year ago

riskmaris commented 1 year ago

Mobile menu

riskmaris commented 1 year ago

Hello, Am really confused now because i updated my linters by setting up the eslint for javascript and the linters passed. So how come you say I did not set them up? Please clarify more on this maybe am the one who does not get it right. Also my partner contributed to my project and I did the same to hers.

thank you

On Wed, 19 Apr 2023 at 12:12, Michael Threels @.***> wrote:

@.**** requested changes on this pull request.

Hi Maris,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code. Invalid Code Review Request

I'm sorry this wasn't mentioned right away in the initial invalidation, however, your project doesn't have eslint setup, as this is a javascript requirement please do so. In addition to that this milestone is a pair programming activity therefore your commit history should show commits from all the team members.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

— Reply to this email directly, view it on GitHub https://github.com/riskmaris/mobile-menu-branch/pull/10#pullrequestreview-1391627191, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4Q6X7HWDH4QX2N4FFBEMVLXB6T7BANCNFSM6AAAAAAXDWXWWY . You are receiving this because you were mentioned.Message ID: @.***>