search

rism-digital / muscat

🗂️ A Rails application for the inventory of handwritten and printed music scores
http://muscat-project.org
34 stars 16 forks source link

Add "http" validation for 856$u in Institutions and People #1492

Open jenniferward opened 8 months ago

jenniferward commented 8 months ago

As in https://github.com/rism-digital/muscat/issues/955, URLs in 856$u in Institutions and People should begin with http.

Tests: https://muscat-test.rism.info/admin/institutions/51007768 https://muscat-test.rism.info/admin/people/51018090

ahankinson commented 8 months ago

"https" also starts with "http" but not all URLs that work with HTTPS also work with HTTP. (That is to say, if the links are being corrected as well as validated, they should be checked over what protocol they are available.)

jenniferward commented 8 months ago

OK - just trying to prevent people from typing in doi.org/10.1093/oso/9780198863045.003.0020 or www.wikipedia.org which do not resolve.

ahankinson commented 8 months ago

Yeah -- I was just observing that if the validation only checks for "http" that this may still not work if the site is also available over https. Technically the validation should check for http:// or https:// since httpwww.wikipedia.org would validate but not be correct.

jenniferward commented 8 months ago

I see - maybe the validation should be adjusted in Sources as well (and elsewhere, see https://github.com/rism-digital/muscat/issues/955) https://muscat-test.rism.info/admin/sources/1001281354