search

rism-digital / muscat

🗂️ A Rails application for the inventory of handwritten and printed music scores
http://muscat-project.org
34 stars 16 forks source link

People: Validation for 024 #1498

Open jenniferward opened 8 months ago

jenniferward commented 8 months ago

If the 024 in Personal Names is filled out at all, then both the $a and $2 should be filled out. Might be similar to https://github.com/rism-digital/muscat/issues/1386

jenniferward commented 5 months ago

I think whenever a value in a drop-down menu is pre-set to a default, it automatically saves the default value even if nothing in $a is filled out. This only happens when a cataloger opens the field, even if the cataloger decides later to fill nothing out. Example: 024 in People is normally closed, but when you open it, VIAF is the default value. image Then if you save, $2VIAF is saved to the record even though nothing was filled out in $a. https://muscat.rism.info/admin/people/30004955?view=MARC21 =024 7#$2VIAF

Even if you switch it to something else, like WKP but then later decide not to add a WKP identifier, then WKP is saved: https://muscat.rism.info/admin/people/20001460?view=MARC21 =024 7#$2WKP

We had that problem in Sources in 730$g with empty RISM values but a validation catches that now.

It was happening in Works in 024 (see https://github.com/rism-digital/muscat/issues/1517) but a validation catches that now.

As a second step we will have to delete the stray VIAF and WKP (and maybe others) values.