rism-digital / muscat

🗂️ A Rails application for the inventory of handwritten and printed music scores
http://muscat-project.org
34 stars 16 forks source link

Comments: mentions followed by punctuation are not sent as emails #1595

Closed jenniferward closed 1 month ago

jenniferward commented 1 month ago

See https://muscat.rism.info/admin/sources/1001119273 https://muscat.rism.info/admin/sources/1001119271 https://muscat.rism.info/admin/sources/1001187437 image

The mentions are directly followed by punctuation. No email is delivered but the comment shows up on the user's dashboard. When I type a name, a space is automatically inserted after the mention, but some people press backspace to insert a comma or colon to make it look like a more natural message. This leads to the intended recipient missing comments, especially if they are used to reacting to email notifications.

Previous issue with comments: https://github.com/rism-digital/muscat/issues/1432