search

rism-digital / muscat

🗂️ A Rails application for the inventory of handwritten and printed music scores
http://muscat-project.org
34 stars 16 forks source link

Should the record status be more visible in the show and edit screen? #1649

Open fjorba opened 1 month ago

fjorba commented 1 month ago

Currently, the record status (wf_stage) is quite visible in Muscat in the record lists (index), for example:

image

However, in the full record view, or in the edit screen, the status is only visible in the bottom part of the record, so discreet that, unless you look at the button of the screen, it is not obvious to know if the record you are watching or editing is published or not:

image

We think that the record status is so important that it should be very visible, and if possible, using the same colors and conventions that in the list, that is, reusing the same ActiveAdmin status_tag. For example, in the record view:

image

Or in the edit screen:

image

We have implemented it for all record types that have wf_status; and yes, we know that some of them are under discussion (#1600), but this can be adjusted later.

I'd like to push my patch upstream if you are also interested in it.

jenniferward commented 1 month ago

You are right, it is not very prominent, and not obvious to all users. In the RISM context, most records are published, so I think it would be important to only flag the unpublished records, but if you have more of a mix where you are then I'd be willing to see how it looks with Pub and Unp. Will see what others think.

fjorba commented 1 month ago

Probably at ZR you mostly edit published records, but for catalogers entering new material, they may find both statuses more often, and probably for them it may be quite useful knowing it.

As for us in our institutional repository, we also have a third status that we also use quite a lot, that is deleted. To explain it very schematically, we don't delete records but keep them in deleted status, because, as we import many records automatically, we don't want wrong records to be duplicated.

And finally, I think it is clearer to know that the status is always shown, rather that it is only shown in this or that case, and try to guess what does it mean if it is not shown. In fact, in our proposal, it doesn't take space.

xhero commented 1 month ago

I personally like this, if you guys @jenniferward don't have a strong opposition for me it is ok