search

rism-digital / muscat

🗂️ A Rails application for the inventory of handwritten and printed music scores
http://muscat-project.org
34 stars 16 forks source link

Remove < and > (&lt;and &gt;) in all fields #349

Open xhero opened 8 years ago

xhero commented 8 years ago

Many fields in around the dataset still contain <and &gt, they have to be converted to < and > or will not display correctly (eg. institution 16353, source 456082627, etc)

lpugin commented 8 years ago

Yes, we should remove all the HTML markup from the content. I can also see that <br> is used in 245. What we would need to do is split them into one 245 and then repeated 246. OK?

@HirschSt how do you want to proceed? This might be too much for this version. Maybe you can just remove all of them for now?

HirschSt commented 8 years ago

We probably have many html entities in various fields in the records, for the moment I can try to erase
and &gt and < but in later releases we should find a way to replace them or to display them correctly; @lpugin can you explain why htmlentities are bad with rails (aside from incorrect display)?

lpugin commented 8 years ago

Yes, I agree that we should look at this for the next release.

The problem is mostly having html entities in MARC and this is not directly related to Rails.

lpugin commented 8 years ago

PS We should distinct the issue of using < and >, which we could just replace with [ and ] for example, and html entities. So for now the fix could be to just replace < with [ and > with ].

HirschSt commented 8 years ago

@lpugin ok

HirschSt commented 7 years ago

This should be opened again because we have a difference now between records of the migration pool and new record. Eg. in http://muscat.rism.info/admin/sources/456081660 we have "[[L']] oeuvre" (as discussed previously), in http://muscat.rism.info/admin/sources/1001023286 there is "<> hölzerne Schwert. Skizzen"; I would propose to change (with a maintenance script) the imported records to the angle bracked version, eg "<<L'>> oeuvre" to have everything in line.