rism-digital / verovio

🎵 Music notation engraving library for MEI with MusicXML and Humdrum support and various toolkits (JavaScript, Python)
https://www.verovio.org
GNU Lesser General Public License v3.0
661 stars 181 forks source link

Tablature: Augmentation dots on rhythm-signs #2525

Closed TimCrawford closed 2 years ago

TimCrawford commented 2 years ago

(Both Italian and French tab) Augmentation dots on the rhythm-signs are too small and close to the signs themselves Aug_dot_on_Italian _lute_tab_rhythmsign

Aug_dot_on_French _lute_tab_rhythmsign

MEI for these examples is the same for Italian and French lute tablature, but with attribute 'notationtype' changed appropriately on line 17

<?xml version="1.0" standalone="no"?>
<mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="4.0.0">
    <meiHead>
        <fileDesc>
            <titleStmt>
                <title>Augmentation dot on tablature rhythm sign - French lute tablature</title>
            </titleStmt>
            <pubStmt />
        </fileDesc>
    </meiHead>
    <music>
        <body>
            <mdiv n="1">
                <score>
                    <scoreDef>
                        <staffGrp>
                            <staffDef n="1" lines="6" notationtype="tab.lute.french">
                                <tuning>
                                    <course n="1" pname="g" oct="4" />
                                    <course n="2" pname="d" oct="4" />
                                    <course n="3" pname="a" oct="3" />
                                    <course n="4" pname="f" oct="3" />
                                    <course n="5" pname="c" oct="3" />
                                    <course n="6" pname="g" oct="2" />
                                    <course n="7" pname="f" oct="2" />
                                    <course n="8" pname="e" oct="2" />
                                    <course n="9" pname="d" oct="2" />
                                    <course n="10" pname="c" oct="2" />
                                </tuning>
                            </staffDef>
                        </staffGrp>
                    </scoreDef>
                    <section n="1">
                        <measure n="1">
                            <staff n="1">
                                <layer n="1">
                                    <tabGrp dur="2" dots="1">
                                        <tabDurSym />
                                        <note tab.course="2" tab.fret="0" />
                                    </tabGrp>
                                    <tabGrp dur="4">
                                        <tabDurSym />
                                        <note tab.course="2" tab.fret="2" />
                                    </tabGrp>
                                </layer>
                            </staff>
                        </measure>
                    </section>
                </score>
            </mdiv>
        </body>
    </music>
</mei>

(Updated 6 Dec 2021)

craigsapp commented 2 years ago

Ideally you should include a short example MEI file that demonstrates the problem. In other words, it is better to extract about a measure's worth of music that illustrates a problem rather than including an entire score. There are two purposes for this: (1) It allows the person trying to fix the problem to test updates to the code to verify that a fix works, and (2) the short example can then be added to the verovio test suite: https://www.verovio.org/test-suite.xhtml, which can be used to monitor future changes to the verovio sourcecode that may break the notation rendering again.

This can be done in two ways:

(1) Zip an XML file and then drag-and-drop the file into the issue input editor. This method is the best for including complete scores of MEI data (about greater than 1000 lines of XML code).

or (2), I find this method more convenient for short examples: these can be displayed directly in the issue webpage by enclosing the MEI content between two lines that only contain three back quotes. To colorize the XML structure, add the text "xml" (with or without a space) after the first line of backticks:

```xml
<xml content>

(3) For longer examples, or when there are multiple examples on a page that would disrupt reading of the text, then having a show/hide toggle of the example code is useful using `<details>` HTML element:
Click to view MEI data for above example. ``` ```` Here is a on-page demo of the above Markdown code:
Click to view MEI data for above example. ```
TimCrawford commented 2 years ago

Dear Craig,

Nice to hear from you and thanks for the detailed advice. This was the first time I have opened a GitHub issue, so no wonder it was all wrong.

I will amend the issues on or after Monday when I get back to my laptop. Extracting minimal code to show these tab problems will take a bit of experimentation so it might take a while!

I hope you are well, still in CA ( I assume ) and not too bogged down with students etc. How is Eleanor these days?

Tim