search

rismm / pe

0 stars 0 forks source link

Quantity parameter of inflow and outflow #6

Open rismm opened 7 months ago

rismm commented 7 months ago

Based on the parameters of the new command, I would also expect the parameter to indicate quantity would also use q/ instead of a/. I feel that there is a lack of consistency in the commands and only adds to confusion of the user.

soc-pe-bot commented 7 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inconsistency in command conventions

image.png

While this may be a nitpick, it is rather confusing that the flag for quantity is sometimes "q/" and sometimes "a/"

[original: nus-cs2113-AY2324S2/pe-interim#553] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi there, thank you for your report.

Having different flags for the "Quantity" field is an intentional choice, as "Quantity" has different purposes in the different commands.

In the add and edit command, q/QUANTITY is used to specify the total quantity of the product. In the inflow and outflow command, a/QUANTITIY is used to specify the change in quantity of the product. Reusing q/QUANTITY for the inflow and outflow command may hence confuse users as to whether they are editing the total quantity of the product, or merely increasing/decreasing the amount.

We hope this clears up the design choice. Nevertheless, thank you for bringing up this concern.

Best Regards, StockPal Team

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Though I do understand your rationale for intentionally having different flags, I would say that you are overthinking this from a user standpoint. I think the meaning behind the command words `inflow` and `outflow` is enough for users to understand what they are changing with the quantity parameter that they input. Fundamentally, both flags do refer to a product item's quantity and as a user, I would prefer if I have less flags to remember or take note of when I am using the program.