search

risoflora / brookframework

Microframework which helps to develop web Pascal applications.
https://risoflora.github.io/brookframework
GNU Lesser General Public License v2.1
239 stars 54 forks source link

Test project does not compile #51

Closed AlexMikh33 closed 8 months ago

AlexMikh33 commented 9 months ago

The test project does not compile. Many errors. Obviously, the test project has not been updated for a long time.

silvioprog commented 9 months ago

Hey @AlexMikh33, Delphi or Lazarus? (or both :sweat_smile:)

silvioprog commented 9 months ago

Also, pls feel totally free to send PR with fix. 🙂

AlexMikh33 commented 8 months ago

Hey @AlexMikh33, Delphi or Lazarus? (or both 😅)

Sorry, it looks like I posted in the wrong thread. Problem with a Test app in your second Brook project - brookfreepascal https://github.com/risoflora/brookfreepascal I was unable to compile it in Lazarus 3.0 (FPC 3.2.2) testbrookaction.pas (line 902): rt.AfterExecuteAction := @AfterExecuteAction; Error: Incompatible types: got "<procedure variable type of procedure(TObject;TBrookAction;TRequest;TResponse;TBrookRoute;var Boolean) of object;Register>" expected "<procedure variable type of procedure(TObject;TBrookAction;TRequest;TResponse;const TBrookArrayOfString;const TBrookArrayOfString;TBrookRoute;var Boolean) of object;Register>"

And as I see this is not the only place.

silvioprog commented 8 months ago

Hey @Al-Muhandis, could you verify? 🙂

Al-Muhandis commented 8 months ago

We figured it out. This test is incomplete. We'd better delete it.

Al-Muhandis commented 8 months ago

We deleted the test folder because it was started, but did not receive a continuation (the framework itself works on work projects: everything is fine). Thanks for the feedback @AlexMikh33