risor-io / risor

Fast and flexible scripting for Go developers and DevOps.
https://risor.io
Apache License 2.0
611 stars 26 forks source link

feat: add k8s module #129

Closed luisdavim closed 9 months ago

luisdavim commented 9 months ago

closes #123

myzie commented 9 months ago

In general this is looking good. You have the k8s package as its own Go module and have it on a build tag, which is what I would do.

luisdavim commented 9 months ago

@myzie I did some testing and made some updates, I think this PR is ready to be reviewed/merged. There's more functionality that we can add later but this should cover the base CRUD use cases and we can wait for user feedback to add more stuff.

myzie commented 9 months ago

I confirmed a basic k8s.get("pod.v1") works for me with Docker for Mac's k8s setup. I don't have another cluster at the moment to test against, so I'll defer to you on confirming anything beyond that for now!

Were the toolchain go1.21.0 go.mod entries getting in the way for you?

luisdavim commented 9 months ago

Yes, I tested against both real clusters and Kind clusters.

The toolchain directives were preventing gopls from working for me.