search

risor-io / risor

Fast and flexible scripting for Go developers and DevOps.
https://risor.io
Apache License 2.0
581 stars 24 forks source link

refactor: http module #146

Closed luisdavim closed 6 months ago

luisdavim commented 7 months ago

closes #141

myzie commented 7 months ago

This is looking great @luisdavim, thank you.

A super small thing: suggest using snake_case on the attribute names in modules/http/http_request.go GetAttr.

luisdavim commented 7 months ago

This is looking great @luisdavim, thank you.

A super small thing: suggest using snake_case on the attribute names in modules/http/http_request.go GetAttr.

Sure, thanks. Should both "fields" and "functions" use snake case?

myzie commented 7 months ago

Yeah, right now everything is snake case across the board.

luisdavim commented 6 months ago

@myzie I think this will get me what I need for my project and the PR is getting big (sorry), so I'm marking this as ready for review and I can open followup PRs as I use it and find gaps or issues, the pre-existing fetch should work as before.