search

risor-io / risor

Fast and flexible scripting for Go developers and DevOps.
https://risor.io
Apache License 2.0
581 stars 24 forks source link

Create a vault module #147

Closed luisdavim closed 6 months ago

luisdavim commented 6 months ago

Hashicorp vault is quite popular, a vault module could be useful.

myzie commented 6 months ago

Sounds good 👍. Let's just keep it on a build flag w/ a separate go.mod like you did with the kubernetes module.

luisdavim commented 6 months ago

Sounds good 👍. Let's just keep it on a build flag w/ a separate go.mod like you did with the kubernetes module.

Sure, BTW should I have done the same with the jmspath module? I did it with the Kubernetes one because of the large amount of dependencies...

myzie commented 6 months ago

I debated bringing that up while reviewing the jmespath PR. For self-contained, small dependencies like that one I think it's less consequential overall, however I do have this rather strong statement in the readme right now:

Risor is designed to have zero external dependencies in its core libraries.

To keep by that policy it should have its own go.mod.

myzie commented 6 months ago

I think putting modules behind a build tag is only necessary for deps that really bloat the size of the CLI binaries. Which is the case for the Go AWS SDK when lots of services are pulled in.

luisdavim commented 6 months ago

I've opened https://github.com/risor-io/risor/pull/150 to fix the jmespath module and give it its own go.mod