Closed myzie closed 6 months ago
Attention: Patch coverage is 53.33333%
with 14 lines
in your changes are missing coverage. Please review.
Project coverage is 31.52%. Comparing base (
297643d
) to head (54aaa70
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
fyi @edhemphill @luisdavim @applejag. I'm guessing you won't object to this simplification, but let me know if otherwise.
Thanks for letting us know.
The limits feature is not much used and was not implemented consistently across different built-ins. This meant it was adding complexity to the codebase without adding much value. Due to gaps in where limits were applied, a developer using Risor may have a false sense of security from it.
Given all that, I'm removing limit related behavior from much of the codebase. The limits mechanism is still available, and can be opted into by writing your own built-ins that leverage it. I did also keep the limits hookup for outgoing HTTP requests specifically, since that was fairly well defined and works.
This also updates the limits implementation to be threadsafe, which is needed now that Risor supports goroutines.