search

risor-io / risor

Fast and flexible scripting for Go developers and DevOps.
https://risor.io
Apache License 2.0
576 stars 24 forks source link

fix panic while accessing proxy object field #233

Open runsisi opened 2 months ago

runsisi commented 2 months ago

Fixes: https://github.com/risor-io/risor/issues/232

Signed-off-by: runsisi runsisi@hust.edu.cn

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.17%. Comparing base (351c79e) to head (6919ab2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #233 +/- ## ========================================== + Coverage 32.99% 33.17% +0.17% ========================================== Files 129 129 Lines 16025 16038 +13 ========================================== + Hits 5288 5320 +32 + Misses 10111 10093 -18 + Partials 626 625 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

runsisi commented 2 months ago

hi @myzie ptal, i am not sure the fix is right :)

the ci failure seems unrelated, but it is rather weird, i have seen it during local test occasionally.

=== Failed
=== FAIL: object TestObjectString (0.00s)
    object_test.go:37: object.String() wrong. want="{true, nil}", got="{true, nil}"