ristekoss / susunjadwal

SusunJadwal - Universitas Indonesia's #1 Student Course Planner App.
http://susunjadwal.cs.ui.ac.id/
34 stars 16 forks source link

feat: add courses endpoint and new data scrapping #117

Closed angga1518 closed 3 years ago

angga1518 commented 3 years ago

It looks likely I accidentally reformat the scapper/main.py file. So kindly check the differences from this link https://www.diffchecker.com/5VXgAaky

for new scrape flow, kindly check the image below

image

Response preview

{
  "courses": [
    {
      "code": "CSGE602012", 
      "credit": 3, 
      "curriculum": "06.00.12.01-2016", 
      "description": "", 
      "name": "Aljabar Linier", 
      "prerequisite": "", 
      "term": 3
    }, 
   {...}
   ]
}

thank you

netlify[bot] commented 3 years ago

✔️ Deploy Preview for susunjadwal canceled.

🔨 Explore the source changes: aa3739dcd849a70374044f61e7703cc202006be0

🔍 Inspect the deploy log: https://app.netlify.com/sites/susunjadwal/deploys/614832353d41af00086af71a

fahdikrie commented 3 years ago

Hello, Kak Angga!

Sorry for the late review. I just tried the newly added /courses endpoint, and it works & integrates just fine with the existing database.

Oh, a bit of a nitpick but I notice that there are inconsistencies on the description & prerequisite field whereas it could either be blank or null for the 'empty' values. Not sure how thats gonna affect anything though, but consider this as a mere heads up to UlasKelas team 😂

Screen Shot 2021-09-15 at 20 09 54

Regarding the best practices, I don't have much experience on the backend so i'm gonna pass the review to Kak Dipta (cc: @hsjsjsj009).

Cheers!