Closed angga1518 closed 3 years ago
✔️ Deploy Preview for susunjadwal canceled.
🔨 Explore the source changes: aa3739dcd849a70374044f61e7703cc202006be0
🔍 Inspect the deploy log: https://app.netlify.com/sites/susunjadwal/deploys/614832353d41af00086af71a
Hello, Kak Angga!
Sorry for the late review. I just tried the newly added /courses
endpoint, and it works & integrates just fine with the existing database.
Oh, a bit of a nitpick but I notice that there are inconsistencies on the description
& prerequisite
field whereas it could either be blank or null for the 'empty' values. Not sure how thats gonna affect anything though, but consider this as a mere heads up to UlasKelas team 😂
Regarding the best practices, I don't have much experience on the backend so i'm gonna pass the review to Kak Dipta (cc: @hsjsjsj009).
Cheers!
It looks likely I accidentally reformat the scapper/main.py file. So kindly check the differences from this link https://www.diffchecker.com/5VXgAaky
for new scrape flow, kindly check the image below
Response preview
thank you