ristekoss / susunjadwal

SusunJadwal - Universitas Indonesia's #1 Student Course Planner App.
http://susunjadwal.cs.ui.ac.id/
34 stars 16 forks source link

Navbar user still visible on 404 page, in condition user not login #38

Closed muhsatrio closed 4 years ago

muhsatrio commented 4 years ago

This issue is a:

Current behavior:

This condition is happened when I am not login as the user (actually, I'm not UI student, so can't try to login with SSO user also), If I go to click URL outside of available routes, like this picture below Screenshot from 2020-07-22 00-18-16 It will show 404 not found page, but still there navbar for user menu who had login

Requested behavior:

Added authorization for navbar to show just if user has been login

Why this behavior is better: To make sure the visitor outside user can not access available menu anymore

muhsatrio commented 4 years ago

@albadrun @mochaul @satraul @genturwt @fatanugraha @fairuzi10 @hilyafesmia

satraul commented 4 years ago

Fixed in #39 Thanks for the contribution! Clean solution