ristekoss / susunjadwal

SusunJadwal - Universitas Indonesia's #1 Student Course Planner App.
http://susunjadwal.cs.ui.ac.id/
34 stars 16 forks source link

Beta testing & regular landing page #82

Closed fahdikrie closed 3 years ago

fahdikrie commented 3 years ago

Changes:

Fixes:

Login feature shouldn't work as of yet since I haven't connect the app to our new/migrated backend. Therefore you can check the pages I implemented by accessing the urls below:

netlify[bot] commented 3 years ago

:heavy_check_mark: Deploy Preview for susunjadwal ready!

:hammer: Explore the source changes: a99c63cae525d32ce8f2d63635fd8ee837bbcf25

:mag: Inspect the deploy log: https://app.netlify.com/sites/susunjadwal/deploys/60e6bf94786cb80007e9090c

:sunglasses: Browse the preview: https://deploy-preview-82--susunjadwal.netlify.app/

leleonardo81 commented 3 years ago

image

does it a bit too big? the asset on right

leleonardo81 commented 3 years ago

This is below 480px image

This is Greater than 900px image

but this is between 480px and 900px The assets on background missing there image

fahdikrie commented 3 years ago

image

does it a bit too big? the asset on right

I think it's about the same size as in Figma (the screenshot on the left) 🤔

Screen Shot 2021-07-08 at 15 52 34 Screen Shot 2021-07-08 at 15 52 39

And on the developer notes, it is said that the chevron should be about 2rem above the bottom of the screen. Do you think I should downsize the asset?
fahdikrie commented 3 years ago

This is below 480px image

This is Greater than 900px image

but this is between 480px and 900px The assets on background missing there image

ah iya yg ini bingung juga sebenernya wkwk. cuma kalo breakpointnya digedein (480px s/d 900px), jadinya kaya gini:

Screen Shot 2021-07-08 at 15 49 15 Screen Shot 2021-07-08 at 15 50 45

karena ngejar 100% width kan, kepikiran solusinya paling dua: assetnya digepengin kaya di figma, atau kontennya diturunin. cuma takutnya jadi malah lebih jelek wkwk, wdyt kak?
leleonardo81 commented 3 years ago

Maybe bisa minta asset baru, orr kalo dijadiin background repeat kesamping gtu aneh ga ya. Bingung juga si iki

On Thu, Jul 8, 2021, 16:03 Fahdii Ajmalal Fikrie @.***> wrote:

This is below 480px [image: image] https://user-images.githubusercontent.com/47312797/124882961-14949800-dffb-11eb-823d-ae16d69eab47.png

This is Greater than 900px [image: image] https://user-images.githubusercontent.com/47312797/124883256-57ef0680-dffb-11eb-89fb-6ccc1f60085c.png

but this is between 480px and 900px The assets on background missing there [image: image] https://user-images.githubusercontent.com/47312797/124883431-82d95a80-dffb-11eb-8857-c468e7d9e467.png

ah iya yg ini bingung juga sebenernya wkwk. cuma kalo breakpointnya digedein (480px s/d 900px), jadinya kaya gini: [image: Screen Shot 2021-07-08 at 15 49 15] https://user-images.githubusercontent.com/47189456/124894214-a6a19e00-e005-11eb-8a0f-784dd3cdf3ad.png [image: Screen Shot 2021-07-08 at 15 50 45] https://user-images.githubusercontent.com/47189456/124894222-a7d2cb00-e005-11eb-93d3-833c4db9c440.png

karena ngejar 100% width kan, kepikiran solusinya paling dua: assetnya digepengin kaya di figma, atau kontennya diturunin. cuma takutnya jadi malah lebih jelek wkwk, wdyt kak?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ristekoss/susunjadwal/pull/82#issuecomment-876266340, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALI67HKELUJWJW2YQLTYG4TTWVSXBANCNFSM5AABJL7A .

leleonardo81 commented 3 years ago

Oh wah emng segede itu ternyata wkwkwkwk. Maybe krna buttonnya aga kecil jdi keliatan gede ya.

Well ya i think its good

On Thu, Jul 8, 2021, 15:58 Fahdii Ajmalal Fikrie @.***> wrote:

[image: image] https://user-images.githubusercontent.com/47312797/124882678-d5664700-dffa-11eb-8db6-c234719ae61c.png

does it a bit too big? the asset on right

I think it's about the same size as in Figma (the screenshot on the left) 🤔 [image: Screen Shot 2021-07-08 at 15 52 34] https://user-images.githubusercontent.com/47189456/124893062-9ccb6b00-e004-11eb-9b1f-13a3da8a7eb0.png [image: Screen Shot 2021-07-08 at 15 52 39] https://user-images.githubusercontent.com/47189456/124893068-9e952e80-e004-11eb-8aa2-0f60aa9e4be8.png

And on the developer notes, it is said that the chevron should be about 2rem above the bottom of the screen. Do you think I should downsize the asset?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ristekoss/susunjadwal/pull/82#issuecomment-876262783, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALI67HLPPDZ3DWLJDG7JOFTTWVSEJANCNFSM5AABJL7A .

fahdikrie commented 3 years ago

Maybe bisa minta asset baru, orr kalo dijadiin background repeat kesamping gtu aneh ga ya. Bingung juga si iki … On Thu, Jul 8, 2021, 16:03 Fahdii Ajmalal Fikrie @.**> wrote: This is below 480px [image: image] https://user-images.githubusercontent.com/47312797/124882961-14949800-dffb-11eb-823d-ae16d69eab47.png This is Greater than 900px [image: image] https://user-images.githubusercontent.com/47312797/124883256-57ef0680-dffb-11eb-89fb-6ccc1f60085c.png but this is between 480px and 900px* The assets on background missing there [image: image] https://user-images.githubusercontent.com/47312797/124883431-82d95a80-dffb-11eb-8857-c468e7d9e467.png ah iya yg ini bingung juga sebenernya wkwk. cuma kalo breakpointnya digedein (480px s/d 900px), jadinya kaya gini: [image: Screen Shot 2021-07-08 at 15 49 15] https://user-images.githubusercontent.com/47189456/124894214-a6a19e00-e005-11eb-8a0f-784dd3cdf3ad.png [image: Screen Shot 2021-07-08 at 15 50 45] https://user-images.githubusercontent.com/47189456/124894222-a7d2cb00-e005-11eb-93d3-833c4db9c440.png karena ngejar 100% width kan, kepikiran solusinya paling dua: assetnya digepengin kaya di figma, atau kontennya diturunin. cuma takutnya jadi malah lebih jelek wkwk, wdyt kak? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#82 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALI67HKELUJWJW2YQLTYG4TTWVSXBANCNFSM5AABJL7A .

Tadi pas weekly ditanyain ke DPD, katanya lebih bagus diilangin daripada digepengin \:D