Collective MoP Final Question Issues

chrissprague commented 9 years ago

Question number - Issue

4 - Fix the LaT_EX issue with the backslashes
11c - Index out of bounds issue possible in answer code line 2 (accessing arr[0])
20 - clarify that the string is of length 7 plus one extra for the null bit
21 - gender should be specified that it is assigned to a 1 or 0, or be made to more accurately reflect the nature of gender, such as being described by a more open-ended char* (e.g. gender should not be considered binary unless we make that an explicit assumption for the sake of the question)
23 - the array(?) size 32 should be changed to something smaller, e.g. 30.

YawarRaza7349 commented 9 years ago

21 and 23 are fixed. Is the comment not enough for 20?

chrissprague commented 9 years ago

@YawarRaza7349 awesome - thanks! (I really appreciate you fixing up 21, and I think the way you did it was great :stuck_out_tongue_winking_eye: )

Regarding 20, this was more of an opinion/discussion point. I wouldn't be surprised if teachers didn't clarify that you needed space for a null bit but expected you to interpret it as char* length 8 with 7 usable bits and 1 terminating null bit. It's up to you. I could go either way (change it or keep it as-is).

khipkin commented 9 years ago

@YawarRaza7349 @chrissprague The comment in 20 is already very clear....

chrissprague commented 9 years ago

Define a union, typedefed to the name printableData, that can hold any of: an seven-character long string, a double, or an int.

@YawarRaza7349 @khipkin No, in my opinion it is not "very clear". It could be interpreted either way - size 8 with a null bit, so a useable length of 7, or the entire string length of 7, resulting in an effective useable length of 6. If this were on an exam, I would personally have to ask the teacher to clarify.

Either way, I will just go ahead an edit the question myself to clarify it. There's no harm in that.

dpk3062 commented 9 years ago

Personally I think it would be better left unclear. It's easy to say it could be interpreted this way or that way when going over the question and thus reminders the students that their interpretation isn't always the same as their peers. Far too many software requirements can be interpreted in different ways and they need to learn to always have their guard up for that and gain the ability to ask what the creator wanted it to mean.

On 12/15/2014 07:37 AM, Christopher Sprague wrote:

Define a union, |typedef|ed to the name |printableData|, that can
hold any of: an seven-character
long string, a |double|, or an |int|.
@YawarRaza7349 https://github.com/YawarRaza7349 @khipkin https://github.com/khipkin No, in my opinion it is not "very clear". It could be interpreted either way - size 8 with a null bit, so a useable length of 7, or the entire string length of 7, resulting in an effective useable length of 6. If this were on an exam, I would personally have to ask the teacher to clarify.

Either way, I will just go ahead an edit the question myself to clarify it. There's no harm in that.

— Reply to this email directly or view it on GitHub https://github.com/rit-csc/csc_exam_reviews/issues/18#issuecomment-66988393.

chrissprague commented 9 years ago

@dpk3062 @khipkin @YawarRaza7349 I think Doug's approach is correct. Well said.

rit-csc / csc_exam_reviews

Collective MoP Final Question Issues #18