rit-sse / hubot

Our slack hubot
0 stars 0 forks source link

Channel specific hubot commands #3

Closed kristenmills closed 8 years ago

kristenmills commented 8 years ago

Overview of how this works

The primary officers will be set to admins. Admins are the only people who have the ability to assign roles. Roles can be assigned only in your private chats with hubot because they don't have ids associated with the commands.

There are two roles that can allow and remove commands: admin and '[channelname]-admin' . If you possess one of those roles, you may run the following commands:

and they will apply to the specific channel your in. Your DM with hubot allows for all commands.

To see all commmands you can run hubot list commands

They are organized into disabled and enabled for a channel. It's sent via DM to you to prevent spam.

Todo List

This is not ready to be deployed but it's a stable point where I want feedback.

weswigham commented 8 years ago

It seems okay; but why did scoreboard.coffee get removed with this?

kristenmills commented 8 years ago

@weswigham I removed scoreboard.coffee because we are going to have that functionality in slushy.

kristenmills commented 8 years ago

The help thing looks like too much of an annoyance so I'm going to nix that.

kristenmills commented 8 years ago

You know what would make more sense: A blacklist approach over a whitelist approach. Imma do that.

weswigham commented 8 years ago

Conditional black lists, so you can ban 'pug bomb 20' but not 'pug bomb 3'?

On Tue, Jul 28, 2015, 12:50 PM Kristen Mills notifications@github.com wrote:

You know what would make more sense: A blacklist approach over a whitelist approach. Imma do that.

— Reply to this email directly or view it on GitHub https://github.com/rit-sse/hubot/pull/3#issuecomment-125734367.

kristenmills commented 8 years ago

@weswigham Yeah make a separate issue pls. I wanna get the basics done and merged before hand.

kristenmills commented 8 years ago

Alright, it looks like middleware features being merged into hubot might happen in the foreseeable future. (see github/hubot#803). I'm going to wait that out before merging this branch.

michaelansel commented 8 years ago

This is awesome! Once #803 merges, you should pull the command blacklist stuff out to a separate module or at least write up a bit to go in patterns.md.

kristenmills commented 8 years ago

@michaelansel Thanks! Yeah I can definitely do that.