R13 match sign up sign in with mockup

rithmschool / elevate

Human resources for the employee.

0 stars 0 forks source link

R13 match sign up sign in with mockup #142

Closed kimberly-johnson closed 4 years ago

kimberly-johnson commented 4 years ago

[x] html was split within render and return so I split up the html into blocks that could be used to create forms for either sign in or sign up. It is now more organized and easy to read.
[x] Edited buttons to say "SIGN IN" and "create an account"
[x] Added Google sign in to sign up form
[x] Added forgot password link to sign in form

Styling is still not 100% but will update later.

kimberly-johnson commented 4 years ago

before screenshots

kimberly-johnson commented 4 years ago

after screenshots Screen Shot 2019-10-16 at 4 54 39 PM

kimberly-johnson commented 4 years ago

Please let me know if you have any suggestions on how to further clean up the code in loginSignUpForm.js.

Nalipp commented 4 years ago

Looks great. A couple additional refactors could be.

Line 85 convert to ternary operator

Line 286 remove inline styles either using bootstrap only or using the .css file

Line 133 'loginState' is a bad variable name, so is 'isLogin' lets change the state variable name and the variable name on 133 to the same name so they match lets use the name 'loginView' instead

kimberly-johnson commented 4 years ago

In addition to the requested changes in previous comment,

-"text" variable previously on line 134 was only being used once and I replaced it with the ternary operator on line 280 -removed unnecessary string interpolation, lines 266-273, line 242