rithyskun / webgrind

Automatically exported from code.google.com/p/webgrind
Other
0 stars 0 forks source link

escape special chars in filenames #31

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. profile a script using smarty template engine
2. open webgrind and search for the include-statement that executes the
compiled template file (has several %s in it's filename)
3. try to "open file"

What is the expected output? What do you see instead?
The listing of the compiled template file should be displayed but most
likely there is an error about "file not found" because some % chars
followed by numbers get resolved to random/weird characters which makes the
filename not existing.

What version of the product are you using? On what operating system?
Webgrind 1.0/PHP 5.2/Ubuntu 8.04 <--> Firefox 3.0.7/MacOSX 10.5.6

Please provide any additional information below.

The fix is pretty trivial. Just escape these chars using encodeURI in
templates/index.phtml in lines 142 and 169. See also attached patch.

Original issue reported on code.google.com by uwe.mesecke@googlemail.com on 9 Mar 2009 at 8:04

Attachments:

GoogleCodeExporter commented 9 years ago
Thank you for the report and patch.

I am having trouble reproducing the issue, but agree that the filenames should 
be urlencoded.

Potential fix committed in r150, could you please verify that it solves the 
issue for you?

Original comment by oett...@gmail.com on 15 Mar 2009 at 6:21

GoogleCodeExporter commented 9 years ago
the fix solved the issue... thanks

Original comment by uwe.mesecke@googlemail.com on 15 Mar 2009 at 7:22