codecov[bot]
commented
4 years ago Codecov Report
Merging #112 into develop will increase coverage by
<.01%. The diff coverage is78.57%.
@@ Coverage Diff @@
## develop #112 +/- ##
===========================================
+ Coverage 87.04% 87.04% +<.01%
===========================================
Files 26 26
Lines 1420 1428 +8
===========================================
+ Hits 1236 1243 +7
- Misses 184 185 +1| Impacted Files | Coverage Δ | |
|---|---|---|
| petitions/channels_tests.py | 100% <100%> (ø) |
:arrow_up: |
| petitions/consumers.py | 76.47% <57.14%> (-0.64%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update b2f9af9...c33649a. Read the comment docs.
ticket
The purpose of this PR is to change how petitions are rendered on paw prints such that they read left-to-right as opposed to down-left-right. Over the course of this PR I changed how the petitions are passed to the frontend as well. It used to be that they would be serialized and sent one at a time, but that is not efficient so now I serialize all of them and then send them all at once. This should also reduce server load.
As a result of that change to the backend, tests that were written incorrectly before began to fail. There was always supposed to be a response to the user when they first connected to the web socket, and the tests didn't account for that. Now upon connecting we look for a non-empty response before continuing.
Additional tests are not needed for this, as nothing new has been added, and this has already been tested for.