search

ritstudentgovernment / PawPrints

PawPrints petition application for the RIT community.
https://pawprints.rit.edu
Apache License 2.0
16 stars 13 forks source link

PAW-24 - Timeline ordering #115

Closed lukasyelle closed 4 years ago

lukasyelle commented 4 years ago

Ticket

This PR is focused on solving the bug that can be seen on petition #391 where the updates are listed in the incorrect order. This was alleviated by using a computed property to sort the timeline based on type of event and date.

I also did a few formatting improvements

No new testing is required for this PR.

codecov[bot] commented 4 years ago

Codecov Report

Merging #115 into develop will increase coverage by 0.69%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #115      +/-   ##
===========================================
+ Coverage    86.94%   87.63%   +0.69%     
===========================================
  Files           26       26              
  Lines         1432     1561     +129     
===========================================
+ Hits          1245     1368     +123     
- Misses         187      193       +6
Impacted Files Coverage Δ
send_mail/tasks.py 99.25% <0%> (-0.75%) :arrow_down:
send_mail/tests.py 100% <0%> (ø) :arrow_up:
petitions/tests.py 98.38% <0%> (+0.09%) :arrow_up:
petitions/views.py 83.24% <0%> (+2.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e19fa2...e8b6c39. Read the comment docs.