search

ritstudentgovernment / PawPrints

PawPrints petition application for the RIT community.
https://pawprints.rit.edu
Apache License 2.0
16 stars 13 forks source link

PAW-57 - New search box #118

Closed lukasyelle closed 4 years ago

lukasyelle commented 4 years ago

Ticket

There have been usability complaints for a while now with paw prints that the search feature is hard to use. This PR fixes that issue by reimplementing the search bar into a much more visible location, while maintaining a consistent look and feel with other parts of the app.

I also took this opportunity to make the search component a bit more "Vue like".

No additional tests were required for this feature.

codecov[bot] commented 4 years ago

Codecov Report

Merging #118 into develop will increase coverage by 2.31%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #118      +/-   ##
===========================================
+ Coverage    84.49%   86.81%   +2.31%     
===========================================
  Files           26       26              
  Lines         1432     1433       +1     
===========================================
+ Hits          1210     1244      +34     
+ Misses         222      189      -33
Impacted Files Coverage Δ
petitions/consumers.py 75.55% <100.00%> (+18.25%) :arrow_up:
petitions/channels_tests.py 100.00% <0.00%> (+25.75%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f41756...30454f5. Read the comment docs.