search

ritstudentgovernment / PawPrints

PawPrints petition application for the RIT community.
https://pawprints.rit.edu
Apache License 2.0
14 stars 14 forks source link

Link metadata not petition dependent #145

Closed Jack-Papel-RIT closed 1 year ago

Jack-Papel-RIT commented 1 year ago

Re-issue of #73, which was closed as resolved, however has not actually been implemented. According to the replies on the issue, it was added by #76, but in reality the embed doesn't contain any metadata related to the petition shared.

As you can see in this screenshot: image The embed doesn't have any data about the petition.

MoralCode commented 1 year ago

looking at #76 it seems to me like this was implemented by adding a separate endpoint for bots that the nginx server (which at quick search doesnt seem to have its config in this repo) would redirect the crawlers to so the opengraph tags get displayed.

To me it seems like this was done because, when you visit a link such as the one you demonstrated, the pawprint displays as a popup (i.e. the HTML markup is always there, its just hidden when it should be displayed), not its own separate page, so the metadata can become weird if another pawprint is thenn opened, but i guess to a bot this isnt a problem.

ill look into this a little more

MoralCode commented 1 year ago

it appears as though the pull request you mentioned is actually implemented but it only works for a specific url in the old format. see screenshot using the current live pawprints.rit.edu site

Screenshot_20230301_121728

as far as i can tell the server side is not involved in the process of fetching a pawprint when a https://pawprints.rit.edu/?p=3525 url is used, that is fetched and displayed by frontend JS.

Jack-Papel commented 1 year ago

Just tested it and it still doesn't appear to work. Is the change live?

Sma-Das commented 1 year ago

Not live yet