search

ritstudentgovernment / RateMyLandlord

Landlord and property rating site designed for the Rochester community. Next: the world.
MIT License
1 stars 0 forks source link

Models #38

Closed zujko closed 8 years ago

snoozan commented 8 years ago

That commit history is messy. Can you do a git reset --soft and then roll all your commits together or into a few?

aaron13michael commented 8 years ago

I don't see the benefits of clumping all the commits into a few and giving a false impression of the commit history. Also can we be more professional than describing things that we don't like as 'messy AF'? It's disrespectful. On Apr 15, 2016 1:10 PM, "Susan" notifications@github.com wrote:

That commit history is messy AF. Can you do a git reset --soft and then roll all your commits together or into a few?

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/ritstudentgovernment/RateMyLandlord/pull/38#issuecomment-210550169

snoozan commented 8 years ago

My logic for rolling the commits together is because there seemed to be many small commits that don't warrant their own messages.

NathanCastle commented 8 years ago

Looks good, feel free to merge at your convenience.