Unify admin and normal navbars

rittaschool / ritta

Modular open source learning/student management system built with TypeScript and NestJS.

https://ritta.fi

Other

45 stars 5 forks source link

Unify admin and normal navbars #137

Closed Eldemarkki closed 2 years ago

Eldemarkki commented 2 years ago

Refactoring to reuse many components between regular and admin users. Reduces amount of copy-pasted code.

Later when we have fully implemented auth, we can get the isAdmin props straight from some useUser hook, and we don't need to do prop-drilling anymore.

lgtm-com[bot] commented 2 years ago

This pull request fixes 1 alert when merging e4148da998d83d7a7812d4373fa03dd0a6f9889c into 6bc976b4b2cfc239acfe93f757e0f8dc58e5a8ca - view on LGTM.com

fixed alerts:

1 for Unused variable, import, function or class