Seeing how this may have come from my feature request about a livereload that everyone seemed to want, Figured I'd give feedback

amc123-glitch commented 7 years ago

First of All, THANK YOU.

Now that I got that out of the way. I Enjoy using vscode and one of the issues I always felt was not having a live reload plugin.

I have had the chance to test out using the live server extension for firefox. Since I am not really a Firefox user when it comes to development, it took me a bit to get it going. Unfortunately for me, Firefox fresh install was freezing up. But I was able to get it loading once firefox stopped crying to me.

I tested with a laravel project which typically load through php artisan serve and then default is usually 127.0.0.1:8000. After implementing your settings I had to tweak it a to: [ "proxyUri": "http://127.0.0.1:8000/" ] and then closed out of vscode and firefox and the terminal, relaunched it worked how I expected.

will I have to use the port that live server gives (5500) to view the project or can I use the default project port (8000)
This may be just coincidental, but after installing the live server extension on vscode my emmet is not working on laravel blade files, only works on html files. (anyone else seeing this or am I just experiencing an issue with emmet)
Update I notice a spike in cpu usage for code helper after the install and turning on the go live extension in vscode. Code Helper cpu usage once go live is on is at 150.24, as soon as I turn it off, it dropped to 47.1 and then quickly to 0.0. Turned it back on it shot to 35 and then spiked to 148.7

I would definitely love to try this out on Chrome, since that is my default browser whenever that is read, and will put it to the test with 2 large projects, 1 being on the MEAN Stack side and the other being on the Laravel side and will gladly update this post to give you more feedback.

In addition this quick test was performed on a mac running high sierra, I will also try this on a windows 10 and ubuntu 16.04 machine to see if there is any different experience between OS.

ritwickdey commented 7 years ago

First, yep! It will come to google chrome within this week.

2nd ...about the cpu usage.... if you don't setup proxy, is this working expected ?

3rd .... I don't know about laravel blade files -> can you give me a simple startup project ?

4th .... For now, you have to use 5500 (whatever Live Server give). [Btw, I'm planing for NOT TO USE PROXY 😄 - If I can do it, you will able to use 8000 for live reload 😄 ]

amc123-glitch commented 7 years ago

Commenting out the proxy/not setting it gives me

Cannot GET /login

Not setting the url for the proxy gives me

Error: connect ECONNREFUSED 127.0.0.1:80

I've let VSCode sit with the live server extension on for a few minutes without doing anything and seems to hover around 140 to 150. This makes my overall system usage 49.07
Think this may be more of an issue with the original extension now that I am playing around with it. As i turned off the browser extension it did not decrease the percentage, however it started jumping back and forth from 140 to 150 like crazy.

As for the laravel blade: [ https://github.com/AnthonyMichaelc/blank_laravel/tree/master ] there is a empty dummy project I just pushed. When I said laravel blade files, I meant in laravel you typically get to use blade template engine to build your html, so for logging in you'd have a login.blade.php (In the latest releases they've added support to use Vue js out of the box). In order to run the project though you will want to have composer and laravel installed so you can run the php artisan serve command, along with any of the other artisan commands like make:auth, key:generate, etc.

As of right now your plugin works exactly how it is expected, my only concern is the cpu usage which is not to bad to where I cannot use anything, but I will also check in with the plugin on vscode because that could be causing the cpu spike when trying to go to the browser plugin.

ritwickdey commented 7 years ago

Emmet is working for me!

About the CPU usage! Can you open a issue request on https://github.com/ritwickdey/vscode-live-server

amc123-glitch commented 7 years ago

Thanks, I did make the issue request. As for emmet it seems like it is an issue with the emmet team thought they'd make things annoying to everyone that uses it and want more configuration to use it in other files besides html files.

interglobalmedia commented 6 years ago

Hi, I just started using VS Code and one of the first things I installed was your live server plugin. However, after a little while, the default port 5500 stopped working for me. What I did to bypass this was set the default port to 0 so that a random port would be chosen for me each time I launched the live server. I did this yesterday. So far so good. We shall see. Hope this helps anyone else who might be having issues with the default fort 5500. I also am on Mac High Sierra, version 10.13.2. Thanks!

ritwickdey commented 6 years ago

Hi @interglobalmedia, thank for the report! I think, you're on wrong repo. This repo is for Browser Extension, not for the vscode.

Anyway, I think you're issue related to https://github.com/ritwickdey/vscode-live-server/issues/54

ritwickdey / live-server-web-extension

Seeing how this may have come from my feature request about a livereload that everyone seemed to want, Figured I'd give feedback #1