search

ritwickdey / vscode-live-sass-compiler

Compile Sass or Scss file to CSS at realtime with live browser reload feature.
https://ritwickdey.github.io/vscode-live-sass-compiler/
MIT License
660 stars 168 forks source link

Hello Glenn, thanks a lot for your extension but I have a suggestion ! #533

Open RS-Raghav-Sharma opened 2 years ago

RS-Raghav-Sharma commented 2 years ago

So I was using Ritwick dey's live sass compiler extension but I encountered a bug and since he is not maintaining that extension the last update was 3 years ago. I began looking for alternatives. So I found your extension from Github. And it works like charm. However, it is missing a crucial feature!

glenn scss

As you probably can see! In your extension, we can't disable output windows as we could in dey's extension. The output window is really annoying when you are writing property and you pause for a second to think but the extension will give you an error in the output window saying you didn't complete the property. How can I if you just don't let me think !!

So that's why I used to disable the output window. So can you please add this feature to your extension as well ?

I am positive it will surely help many people like me. Again thanks a ton for your extension :)

glenn2223 commented 2 years ago

Hey @RS-Raghav-Sharma, thanks for the message!

Firstly, it's always better to post these issues on my own GitHub repo.

In answer to your question, I have actually changed that setting - which is why setting it to false doesn't change anything. To reflect the overhaul it has had, I changed the name too. It's actually strange that VS Code hasn't greyed it out, stating that it doesn't exist.

It's now called showOutputWindowOn - which you can read about here. It now acts a little more like a logger in the sense you set the level of notification you wish to receive. You can choose to only be shown errors or even nothing at all! Its default is Information to reflect the current state of Ritwick's extension. However, I'd personally recommend setting it to Warning or Error.

You can also see a migration guide here

RS-Raghav-Sharma commented 2 years ago

Got it ! Thanks a ton Glenn 🙌

On Fri, 16 Jul 2021, 2:38 pm Glenn, @.***> wrote:

Hey @RS-Raghav-Sharma https://github.com/RS-Raghav-Sharma, thanks for the message!

Firstly, it's always better to post these issues on my own GitHub repo.

In answer to your question, I have actually changed that setting - which is why setting it to false doesn't change anything. To reflect the overhaul it has had, I changed the name too. It's actually strange that VS Code hasn't greyed it out, stating that it doesn't exist.

It's now called showOutputWindowOn - which you can read about here https://github.com/glenn2223/vscode-live-sass-compiler/blob/master/docs/settings.md#livesasscompilesettingsshowoutputwindowon. It now acts a little more like a logger in the sense you set the level of notification you wish to receive. You can choose to only be shown errors or even nothing at all! Its default is Information to reflect the current state of Ritwick's extension. However, I'd personally recommend setting it to Warning or Error.

You can also see a migration guide here https://github.com/glenn2223/vscode-live-sass-compiler/blob/master/docs/faqs.md#q-im-migrating-from-ritwick-deys-extension-what-do-i-need-to-know

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ritwickdey/vscode-live-sass-compiler/issues/533#issuecomment-881296861, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUN2ZJUZDCHNNUICFEYHJPDTX7ZJ5ANCNFSM5APAPHQQ .