Cant require(embed-js) in Node

[pursual]

var EmbedJS = require('embed-js');

Gives error

TypeError: Cannot read property 'fetch' of undefined
    at /xxx/node_modules/embed-js/src/embed.js:916:15
    at /xxx/node_modules/embed-js/src/embed.js:1299:7

[ritz078]

any chance I can see the code ?

[pursual]

That is the code so far. It fails as soon as I require. I haven't gotten past that point. Might be a node thing? v4.4.7

[ritz078]

I tried it and its working fine for me. are you sure you are using v4.1.4 ? maybe if I can see your code, I will be able to help or if its not possible lets discuss here. can you send the screenshot ?

[pursual]

I installed by npm and it seems to be 4.1.4. I was able to get it to work by setting self = {}; and commenting out the references to "window" in the default options. Its obviously not really meant to run in node. Like I said, there is no code for you to see. It fails on require because self is undefined.

[pursual]

Node doesnt have a "self" or "window" global...so your code wont work.

[ritz078]

of course this is not an isomorphic code. it will only run on client side :)

[pursual]

Yeah, just confusing that you use npm, which is mainly for node. I wanted to use it in Node with the .text() function.

[ritz078]

I will try to make this isomorphic.

[MaxLeiter]

being able to do server-side fetching would be awesome (esp. for caching)

[ritz078]

yes. for that i will also have to separate code that handles interactions like click, load etc. But that should be surely doable.

[niko-h]

I installed embedjs via meteor npm install --save embed-js and the module seems to be installed properly @4.1.13. Requiring it via import EmbedJS from 'embed-js'; does not work though. It gives me an

Uncaught Error: Cannot find module 'embed-js'

Any suggestions?

[ritz078]

If the error is that the module hasn't been found, it should be something specific to meteor. Someone with meteor experience may help.

[niko-h]

I guess some kind of meteor-wrapper-package would have to be written. Unfortunately I don't see myself up to this task. Thumbs up anyway for embed.js! Didn't find an alternative with as many supported embeds yet.

[ritz078]

@niko-h Can you open a separate issue so that I can try to fix this.

[ritz078]

isomorphic support available in v5 beta.