ritz078 / embed-js

🌻 A lightweight plugin to embed emojis, media, maps, tweets, code and more. ✨
https://codesandbox.io/s/Wp5OlNMn
MIT License
1.27k stars 89 forks source link

Update gitignore to ignore generated files in src/ #187

Closed MaxLeiter closed 7 years ago

MaxLeiter commented 7 years ago

Closes #185

MaxLeiter commented 7 years ago

bump, @ritz078 ?

ritz078 commented 7 years ago

I am just figuring out a better way to do this. removing build files totally from that folder and putting them inside specific folders that can be excluded from git.

MaxLeiter commented 7 years ago

It's probably also worth setting up an npm prepublish command so similar files are ignored until published to npm

ritz078 commented 7 years ago

Few things:

This will take some time as will need to refactor the folder structure.

MaxLeiter commented 7 years ago

just an fyi, this PR doesn't change the dist folder

ritz078 commented 7 years ago

i know that. I will just change the folder structure and write prepublish scripts so the dists get created before publish.

ritz078 commented 7 years ago

fixed in master