search

ritz078 / embed-js

🌻 A lightweight plugin to embed emojis, media, maps, tweets, code and more. ✨
https://codesandbox.io/s/Wp5OlNMn
MIT License
1.27k stars 88 forks source link

Hide the embedded url #194

Closed Matoo125 closed 7 years ago

Matoo125 commented 7 years ago

Hello, this is beautiful plugin. I have one question. How can I hide the url of embedded video or picture?

Now I do it with class 'hidden' (display:none). I put every media link inside hidden paragraph and then it works as I want. I am just wondering if there is some build in option for that

ritz078 commented 7 years ago

set {inlineText: false} in options.

Matoo125 commented 7 years ago 
EmbedJS.setOptions({
    link:false,
    inlineText: false   
});

I used this and now It embeds first video multiple times (for each video it shows first video)

https://postimg.org/image/f55kgqjyb/ - screen https://postimg.org/image/m9ndprr7n/ - code

ritz078 commented 7 years ago

Can you create a codepen demo by forking http://codepen.io/ritz078/pen/QjZded ? It will be helpful.

Matoo125 commented 7 years ago

http://codepen.io/Matoo125/pen/rWRZZx Here it is edit: I forgot to save it not it is wokring (or not working) successfuly

ritz078 commented 7 years ago

This is definitely a bug. Thanks for reporting.

Matoo125 commented 7 years ago

good job.

I downloaded version from npm, but i cannot see it embedding visual part, just text and description

https://s30.postimg.org/eibb4nd4h/Capture.png

and in your docs yt example is not working https://embedjs.readme.io/docs/youtubevimeo

ritz078 commented 7 years ago

check with v4.1.12 and doc example seems to be working fine.

Matoo125 commented 7 years ago

https://s28.postimg.org/wvk7f6nlp/Screenshot_from_2017_01_25_20_24_37.png same in chrome / opera / firefox .. also opengraph and markdown looks the same.

downloaded again with npm and now it's working. Thank you, will make use of it :1st_place_medal: