search

ritz078 / embed-js

🌻 A lightweight plugin to embed emojis, media, maps, tweets, code and more. ✨
https://codesandbox.io/s/Wp5OlNMn
MIT License
1.27k stars 88 forks source link

fix(ustream): corrects the url for ustream #215

Closed SnehaMidha closed 7 years ago

SnehaMidha commented 7 years ago

This issue was not mentioned but the rendered link was not valid for ustream .This commit fixes that issue.

ritz078 commented 7 years ago

I think it works good even now https://codepen.io/ritz078/pen/QpKQQy . Can you fork this and give an example where this doesn't work ? I am using v4.1.16.

Edit: Ustream is broken because the recorded term is not removed from the URL.

SnehaMidha commented 7 years ago

Everything woks fine on codepen but on my system, using the file demo/index.html, this appears with old code: image It says that we are trying to access the link as http://www.http//www.ustream.tv/embed/1524, and it works fine only after changing that line.

ritz078 commented 7 years ago

In that case can't add //www blindly in front. There should be a check whether its already present.

ritz078 commented 7 years ago

Also I see test is breaking

ritz078 commented 7 years ago

Have you tested with any example ?