search

ritz078 / embed-js

🌻 A lightweight plugin to embed emojis, media, maps, tweets, code and more. ✨
https://codesandbox.io/s/Wp5OlNMn
MIT License
1.27k stars 88 forks source link

createTest function and test cases #224

Closed ishakalra closed 7 years ago

ishakalra commented 7 years ago

Updated the function to handle an empty string and added 4 test cases to check the same.

MaxLeiter commented 7 years ago

Can you also cleanup the commit log with a git rebase -i HEAD~N where N = commits to squash? Or can it be squashed on merge, @ritz078?

ritz078 commented 7 years ago

I will just squash and merge. I don't see any important commit that will be lost