Closed jackhsu978 closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/ritz078/synth/i1xlz6jgx ✅ Preview: https://synth-git-fork-jackhsu978-range-presets.ritz078.vercel.app
This is a nice addition. Thank you for this. I have left few comments.
Also, I think we can improve the design of the dropdown a bit. I was thinking maybe something like this:
WDYT?
SGTM!
I tweaked the range dropdown UI based on your feedback:
I initially made selecting a preset dismiss the dropdown, but I realized it is weird when it's inconsistent with the custom slider. I updated this PR and now selecting a preset does not dismiss the dropdown.
Thank you for your contribution 🎉
Add the following features for the piano range:
C3-C5
F2-C5
C3-C6
C2-C6
C2-C7
A0-C8
D2-E6
(51 keys) toC2-C6
(49 keys layout, which is common)window.localStorage