ritz078 / raaga

🎹 An online app to play and learn music on a keyboard.
https://raaga.riteshkr.com
133 stars 23 forks source link

feat: add range presets, change default range, and make range preference persistent #102

Closed jackhsu978 closed 4 years ago

jackhsu978 commented 4 years ago

Add the following features for the piano range:

Screenshot 2020-08-02 22 41 06

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ritz078/synth/i1xlz6jgx ✅ Preview: https://synth-git-fork-jackhsu978-range-presets.ritz078.vercel.app

jackhsu978 commented 4 years ago

This is a nice addition. Thank you for this. I have left few comments.

Also, I think we can improve the design of the dropdown a bit. I was thinking maybe something like this:

Untitled-2020-06-29-1349

WDYT?

SGTM!

I tweaked the range dropdown UI based on your feedback:

Screenshot 2020-08-03 23 34 22

I initially made selecting a preset dismiss the dropdown, but I realized it is weird when it's inconsistent with the custom slider. I updated this PR and now selecting a preset does not dismiss the dropdown.

ritz078 commented 4 years ago

Thank you for your contribution 🎉