riul88 / call-recorder-for-android

call-recorder-for-android fork
159 stars 98 forks source link

It doesn't record private number calls #21

Open jbouclier opened 9 years ago

jbouclier commented 9 years ago

It records all outgoing and incoming calls, but the ones coming from private or unknown numbers. Its a feature I'd like to have in this app. If recording private number calls is not expected behavior, at lest you could add a note/warning at project's description.

thanks.

robinpaulson commented 9 years ago

I think it should record everything, or at least provide the option of recording/not recording calls from unknown numbers.

N-zyme commented 8 years ago

I can confirm this issue. App also gives false indication that recording is taking place by displaying the app's icon in the status bar during a call it is not recording.

I lost 90 minutes of interview this morning thanks to this.

reenhilm commented 8 years ago

Not sure if this is "Callrecorder by Skvalex" Confirming however if it is... I have the same issue on my unrooted Samsung Galaxy Note 3 (SM-N9005) Android v5.0.

FileHelper.getFilename might cause an Exception if phone number is empty. One sollution would be to instead of throwing an exception just use a made up constant number in that function, maybe ten zeros (0000000000)?