search

riuson / lcd-image-converter

Tool to create bitmaps and fonts for embedded applications, v.2
https://lcd-image-converter.riuson.com/
GNU General Public License v3.0
337 stars 80 forks source link

simple bugfixes #70

Closed arBmind closed 3 years ago

arBmind commented 3 years ago
  1. Workaround complaints from monochrome QImage that won't allow pixel manipulations.

If no mask is used we can skip this step. note: The bug remains, that monochrome images cannot be masked.

  1. Crash on preview dialog close

Because the QObject was delete while the event handler is active the application crashed for me in debug mode. Using deleteLater() is always the safe option for QObjects.

riuson commented 3 years ago

Hello!

  1. This optimization does not significantly affect the execution speed. How did you determine that the QImage is monochrome and that these pixel manipulation functions are not applicable?
  2. I can't reproduce app crashing on dialog close. What version of Qt and OS you are using?
arBmind commented 3 years ago

I debugged the issue. My System is on Windows 10 and I used Qt 5.15.2

The goal is not the optimization for speed. The problem is that on a QImage that is monochrome, the manipulation not supported and spits out a lot of annoying warnings that makes it hard to debug the program.

riuson commented 3 years ago

Thank you. Branch develop was updated.