search

rivasbolinga / my-things

Console app that helps to keep a record of different type of things we can own like books, music albums movies and games
2 stars 1 forks source link

Ruby group capstone #19

Open mohametalmeari opened 10 months ago

mohametalmeari commented 10 months ago

https://github.com/rivasbolinga/my-things/projects/1 We are three people working together Student A: @momo-87 Student B: @mohametalmeari Student C: @rivasbolinga

Project documentation video: https://drive.google.com/file/d/1c0XJ-86VcacXnDZTQ67CyTB1Hj5Rl6rV/view?usp=sharing

Davidosky007 commented 10 months ago

Hi @mohametalmeari @rivasbolinga @momo-87 👋,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

franclobo commented 10 months ago

Hi @mohametalmeari @rivasbolinga @momo-87,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted the wrong link, please submit the link to your PR

  1. For group capstone projects the correct flow for requesting reviews is Github flow which means dev merging to main.
  2. For solo capstone projects the flow for requesting reviews is Gitflow which means feature branch merging to dev.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.