search

rive-app / rive-ios

iOS runtime for Rive
MIT License
510 stars 58 forks source link

Midflight model changes #166

Closed duncandoit closed 2 years ago

mjtalbot commented 2 years ago

(would also love a little tldr on the change, just to have a slightly easier time figuring out what the change is, but its no biggie)

duncandoit commented 2 years ago

LGTM, i think we should add a test to at least refreshWith viewmodel where we change the viewmodel, and make sure that that behaves as expected.

I can take the commented code out of the example it's in and make a new example just for that purpose. But the commented out code in SwiftMultipleArtboard was there to test that functionality

mjtalbot commented 2 years ago

LGTM, i think we should add a test to at least refreshWith viewmodel where we change the viewmodel, and make sure that that behaves as expected.

I can take the commented code out of the example it's in and make a new example just for that purpose. But the commented out code in SwiftMultipleArtboard was there to test that functionality

that sounds great