search

rive-app / rive-ios

iOS runtime for Rive
MIT License
491 stars 57 forks source link

Only exposes instances #171

Closed mikerreed closed 2 years ago

mikerreed commented 2 years ago

We don't use animations or machines (or artboards), only their instances, so only expose Swift wrappers for those.

mikerreed commented 2 years ago

rubber stamp

does what it says as far as i can tell

what is the change for layer state here btw, it didnt quite fit the pattern of animation/instance?

Also does this change affect how we can "browse" a rive file in code (i assume it doesn't, we can still list out animations/state machines/ inputs etc, just maybe it happens in something wrapped in an instance that we discard?)

is this a strategy we are trying to implement across our runtimes? I'm thinking wasm & android here. I think changing something in the animation as opposed to an instance is totally a mistake, as it is a destructive operations and requires the user to essentially reload the file to get back to a known state so. would be great to chat about this with the engineers i think

Yes, I think this is a trend for all runtimes. The cpp itself was amended earlier to allow instances to do whatever is needed -- no need to refer to the origianl.