search

rive-app / rive-ios

iOS runtime for Rive
MIT License
484 stars 55 forks source link

User provided Bundle #226

Closed Antonito closed 1 year ago

Antonito commented 1 year ago

This PR adds a way to pass a user-provided Bundle (which defaults to .main) when loading an animation from a file.

This is useful when loading files from a Swift Package Manager target (.module bundle) or from a library.

RobertDresler commented 1 year ago

+1 please, this is crusial for us, who develop the app using SPM and have modularized app!

RobertDresler commented 1 year ago

@luigi-rosso

RobertDresler commented 1 year ago

I fixed the logic in #250

mjtalbot commented 1 year ago

thank you @Antonito & @RobertDresler for the pr! Looks like a great enhancement, we'll get his change applied to our repo behind the scenes and pushed out into the public repo in the coming days! (we'll probably go with the adjusted changes in #250)

zplata commented 1 year ago

Closing as this should be fixed in v4.0.3