search

rive-app / rive-ios

iOS runtime for Rive
MIT License
468 stars 53 forks source link

Add support for injecting Bundle when creating RiveFile #250

Closed RobertDresler closed 1 year ago

davidscheutz commented 1 year ago

Let's get this reviewed and merged please 🙌

ilyakuteev commented 1 year ago

Hey @RobertDresler, I've created an issue https://github.com/rive-app/rive-ios/issues/259 showing the problem with unconditional main bundle usage.

Seems like your PR fixes this issue.

ilyakuteev commented 1 year ago

Maybe we should also use this method here: https://github.com/rive-app/rive-ios/blob/4.0.2/Tests/RiveDelegatesTest.swift#L19? This would make tests more clear and also will make sure that bundle parameter is working correctly.

JustJakeCalifornia commented 1 year ago

Let's get this PR merged asap. Unfortunately, this issue blocks our entire team.

zplata commented 1 year ago

Hi! Sorry for the silence here - we'll get this change merged in shortly

zplata commented 1 year ago

Hey all - this change was merged from our upstream repo and released in v4.0.3. Thanks for your contribution @RobertDresler!